Skip to content

Fix: check the result iterator init in print_report_port_xml #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenbonebot merged 2 commits into from
Sep 23, 2026
Merged

Fix: check the result iterator init in print_report_port_xml #3151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94a94b0
Fix: check the result iterator init in print_report_port_xml
mattmundell Sep 22, 2026
62c2e1c
Merge branch 'main' into fix/89-use-of-an-uninitialised-result-iterat…
ozgen Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/manage_sql_report_ports.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ report_port_count (report_t report)
* @param[in] host_filter Exact host filter to apply to the results,
* or NULL for no filter.
*
* @return 0 on success, -1 error.
* @return 0 on success, 2 if the filter was not found, -1 error.
*/
int
print_report_port_xml (print_report_context_t *ctx, report_t report, FILE *out,
Expand All @@ -264,9 +264,17 @@ print_report_port_xml (print_report_context_t *ctx, report_t report, FILE *out,
const gchar *host_filter)
{
result_buffer_t *last_item;
int init_ret;
ctx->ports = g_array_new (TRUE, FALSE, sizeof (gchar *));

init_result_get_iterator (results, get, report, host_filter, NULL);
init_ret = init_result_get_iterator (results, get, report, host_filter, NULL);
if (init_ret)
{
/* Leave the iterator valid and empty, so that the callers can clean
* it up even though the init failed before touching it. */
init_iterator (results, "SELECT NULL WHERE false;");
Comment thread
ozgen marked this conversation as resolved.
return init_ret == 2 ? 2 : -1;
}

/* Buffer the results, removing duplicates. */

Expand Down Expand Up @@ -426,7 +434,7 @@ print_report_port_xml (print_report_context_t *ctx, report_t report, FILE *out,
* @param[in] host_filter Exact host filter to apply to the results,
* or NULL for no filter.
*
* @return 0 on success, -1 error.
* @return 0 on success, 2 if the filter was not found, -1 error.
*/
int
print_report_port_xml_summary_or_details (print_report_context_t *ctx,
Expand Down
Loading