Repository navigation
Improve type information for the Button component - #5724
Merged
Merged
Conversation
The value of a Button can have only one specific type at the same time. Therefore use generics to define the input and output types of the button. A button can have a convert function that converts the input type to an output type. For example a string input that is converted to an integer. Also derive the type from its parent class so all possible props are known and defined.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
greenbonebot
enabled auto-merge (rebase)
October 16, 2026 06:54
daniele-mng
approved these changes
Oct 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5724 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 1326 1326
Lines 34624 34624
Branches 10372 10372
=======================================
Hits 30404 30404
Misses 3818 3818
Partials 402 402 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve type information for the Button component
Why
The value of a Button can have only one specific type at the same time. Therefore use generics to define the input and output types of the button. A button can have a convert function that converts the input type to an output type. For example a string input that is converted to an integer.
Also derive the type from its parent class so all possible props are known and defined.