Allow to pass a ToString as title to DataDisplays - #5661
Merged
Merged
Conversation
Don't require to pass a function if a function is not necessary for generating a display title.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
bjoernricks
force-pushed
the
data-display-types
branch
from
September 25, 2026 10:04
a92c694 to
65bd711
Compare
bjoernricks
marked this pull request as ready for review
September 25, 2026 10:04
greenbonebot
enabled auto-merge (rebase)
September 25, 2026 10:04
daniele-mng
approved these changes
Sep 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5661 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 1304 1304
Lines 34135 34137 +2
Branches 10322 10285 -37
=======================================
+ Hits 29719 29721 +2
Misses 3977 3977
Partials 439 439 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow to pass a ToString as title to DataDisplays
Why
Don't require to pass a function if a function is not necessary for generating a display title.
References
https://jira.greenbone.net/browse/GEA-2019
Checklist