Skip to content

Allow to pass a ToString as title to DataDisplays - #5661

Merged
greenbonebot merged 1 commit into
mainfrom
data-display-types
Sep 25, 2026
Merged

greenbonebot merged 1 commit into
mainfrom
data-display-types

Conversation

@bjoernricks

Copy link
Copy Markdown
Contributor

What

Allow to pass a ToString as title to DataDisplays

Why

Don't require to pass a function if a function is not necessary for generating a display title.

References

https://jira.greenbone.net/browse/GEA-2019

Checklist

  • I have added tests for the changes
  • I have used the following LLMs/AI tools in this pull request:

Don't require to pass a function if a function is not necessary for
generating a display title.
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 65bd711.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@bjoernricks
bjoernricks marked this pull request as ready for review September 25, 2026 10:04
@bjoernricks
bjoernricks requested a review from a team as a code owner September 25, 2026 10:04
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 25, 2026 10:04
@greenbonebot
greenbonebot merged commit c6459eb into main Sep 25, 2026
24 checks passed
@greenbonebot
greenbonebot deleted the data-display-types branch September 25, 2026 10:27
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.06%. Comparing base (cf60650) to head (65bd711).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5661   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files        1304     1304           
  Lines       34135    34137    +2     
  Branches    10322    10285   -37     
=======================================
+ Hits        29719    29721    +2     
  Misses       3977     3977           
  Partials      439      439           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants