Skip to content

Centralize route url paths - #5648

Merged
bjoernricks merged 7 commits into
mainfrom
centralize-route-url-paths
Sep 23, 2026
Merged

bjoernricks merged 7 commits into
mainfrom
centralize-route-url-paths

Conversation

@daniele-mng

@daniele-mng daniele-mng commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Centralize url and paths in one file.

Why

  • Avoid having strings as url and paths.

References

GEA-2090

Checklist

  • I have added tests for the changes
  • I have used the following LLMs/AI tools in this pull request: OpenAI Terra/Luna 5.6

@daniele-mng
daniele-mng force-pushed the centralize-route-url-paths branch from 26a5303 to 0602268 Compare September 23, 2026 10:22
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 3d21bd0.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@daniele-mng
daniele-mng force-pushed the centralize-route-url-paths branch from 0602268 to e841e7c Compare September 23, 2026 10:23
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.09040% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (42ffcbc) to head (3d21bd0).

Files with missing lines Patch % Lines
src/web/route-paths.ts 84.37% 10 Missing ⚠️
src/web/components/structure/Header.tsx 50.00% 1 Missing ⚠️
...board/OperatingSystemVulnerabilityScoreDisplay.tsx 0.00% 1 Missing ⚠️
src/web/pages/reports/ReportListPage.tsx 0.00% 1 Missing ⚠️
src/web/pages/tasks/TaskDetailsPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5648      +/-   ##
==========================================
- Coverage   87.02%   87.02%   -0.01%     
==========================================
  Files        1303     1304       +1     
  Lines       33987    34049      +62     
  Branches    10166    10167       +1     
==========================================
+ Hits        29578    29630      +52     
- Misses       3972     3982      +10     
  Partials      437      437              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniele-mng
daniele-mng force-pushed the centralize-route-url-paths branch from e841e7c to baaf556 Compare September 23, 2026 11:09
@daniele-mng
daniele-mng marked this pull request as ready for review September 23, 2026 11:11
@daniele-mng
daniele-mng requested a review from a team as a code owner September 23, 2026 11:11
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 23, 2026 11:12
Comment thread src/web/components/structure/Header.tsx Outdated
Comment thread src/web/pages/audits/AuditDetailsPageToolBarIcons.tsx Outdated
Comment thread src/web/pages/cves/Details.jsx Outdated
Comment thread src/web/pages/extras/FeedStatusPage.tsx Outdated
Comment thread src/web/pages/extras/FeedStatusPage.tsx Outdated
@daniele-mng
daniele-mng force-pushed the centralize-route-url-paths branch from baaf556 to 64ff2e9 Compare September 23, 2026 11:47
Comment thread src/web/pages/hosts/DetailsPage.jsx Outdated
Comment thread src/web/pages/extras/FeedStatusPage.tsx Outdated
Comment thread src/web/pages/extras/FeedStatusPage.tsx Outdated
Comment thread src/web/pages/nvts/NvtDetails.tsx Outdated
Comment thread src/web/pages/reports/details/operating-system/OperatingSystemsTable.tsx Outdated
Comment thread src/web/pages/OmpPage.tsx Outdated
Comment thread src/web/pages/OmpPage.tsx Outdated
Comment thread src/web/pages/OmpPage.tsx Outdated
Comment thread vite.config.ts Outdated
Comment thread tsconfig.json Outdated
Comment thread src/web/pages/cves/Row.jsx Outdated
bjoernricks
bjoernricks previously approved these changes Sep 23, 2026
Add canonical route descriptors, router path and legacy redirect integration, import-path configuration, and route-path coverage.
Use canonical routes for navigation, links, menu matching, authentication redirects, and entity URL resolution.
- Moved route paths from 'routePaths' to 'web/route-paths' across multiple components.
- Updated imports in various files including CVE, host, NVT, and report pages.
- Added unit tests for route paths to ensure functionality and compatibility.
- Adjusted TypeScript configuration and Vite config to reflect new path structure.
@daniele-mng
daniele-mng force-pushed the centralize-route-url-paths branch from cc26301 to 3d21bd0 Compare September 23, 2026 13:58
@bjoernricks
bjoernricks merged commit f1316b8 into main Sep 23, 2026
25 checks passed
@bjoernricks
bjoernricks deleted the centralize-route-url-paths branch September 23, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants