[EC203] Detect unoptimized image format - GCI203

[ValentinLeTallec]

• PR ecoCode
• PR ecoCode-java-test

[dedece35]

HI @jycr, as SVG expert, are you OK with this implementation ?
for me, all seems OK but if we accept this PR, all images except SVG will be prohibited. Is it that we want ?

[ValentinLeTallec]

For info, I took inspiration from the python implementation of the rule, which use the same exclusion list.
As such, if change are necessary on the java rule implementation, then the python implementation will probably also need to be changed.

[jycr]

@dedece35:

all images except SVG will be prohibited. Is it that we want ?

see my comment: green-code-initiative/creedengo-rules-specifications#153 (comment)

[dedece35]

@dedece35:

all images except SVG will be prohibited. Is it that we want ?

see my comment: green-code-initiative/ecoCode#153 (comment)

I understand that, we can't make this rule as a global rule ! Thus, we can't accept it. OK with it ?

[utarwyn]

Hello,
I'd also like to comment because this rule exists in the repository (EC31) and was originally targeting React/HTML. It authorizes various image formats to mitigate this problem. There's no need to recreate a new EC203 rule.

Please consult the documentation here and the PR green-code-initiative/creedengo-rules-specifications#269.

I see that another PR has been opened for this rule: #52, maybe we can merge both works?

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

Hello, I'd also like to comment because this rule exists in the repository (EC31) and was originally targeting React/HTML. It authorizes various image formats to mitigate this problem. There's no need to recreate a new EC203 rule.

Please consult the documentation here and the PR green-code-initiative/ecoCode#269.

I see that another PR has been opened for this rule: #52, maybe we can merge both works?

Hi @utarwyn,
I absolutely agree with you ... but EC31 is declared on ecocode-rules-specifications but not yet implemented on javascript plugin. Am I right ? I found this PR green-code-initiative/creedengo-javascript#46 ... is it in review ?

I think we can wait this PR 46 and thhen, we will do the work to merge EC203 into EC31 (for Python) and review the current PR next.
What do you think @utarwyn about it ?
Do you think you can review quickly this javascript PR ?

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

I mark this PR as Draft until decision about all PRs about the same subject :

• [EC203] Detect unoptimized image format - GCI203 #47
• add new rules for EC203 #55
• [EC203][Java] Detect unoptimized image format creedengo-rules-specifications#324
• Add new rule EC31: Prefer lighter formats for image files creedengo-rules-specifications#330
• Add new rule EC31: Prefer lighter formats for image files #52
• Add rule "Prefer lighter formats for image files" creedengo-javascript#46
• Add rule "Prefer lighter formats for image files" creedengo-rules-specifications#269
• Add rule "Prefer lighter formats for image files" creedengo-rules-specifications#335

check comment about the subject in PR #47

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!