SWAPI example: construct schema from SDL

[IvanGoncharov]

Motivation #1379

[IvanGoncharov]

There no way to assign enum values after schema constructed.
@leebyron What do you this about adding one more option to buidlSchema/extendSchema?

const schema = buildSchema(sdl, {
  extraConfig: {
    types: {
      Episode: {
        values: {
          NEWHOPE: { value: 4 },
          EMPIRE: { value: 5 },
          JEDI: { value: 6 },
        },
      },
    },
  },
});

[leebyron]

Likewise buildSchema does not provide resolvers or resolveType functions - I think this is probably more appropriate for the graphql-tools which provides additional runtime behavior atop buildSchema

[langpavel]

I'm implementing this in #1987, it may look like:

const schema = buildSchema(sdl, {
  resolvers: {
    Episode: {
      NEWHOPE: 4,
      EMPIRE: 5,
      JEDI: 6,
    },
  },
});

if merged of course :-)
See this test:

graphql-js/src/utilities/__tests__/buildASTSchema-test.js

Lines 98 to 123 in 84adacf

	it('can lookup enum values', () => {
	const schema = buildSchema(
	`
	enum Color { RED, GREEN, BLUE }
	type Query {
	colors: [Color!]!
	}
	`,
	{
	resolvers: {
	Query: {
	colors: () => [4, 2, 1],
	},
	Color: {
	RED: 1,
	GREEN: 2,
	BLUE: 4,
	},
	},
	},
	);
	expect(graphqlSync(schema, '{ colors }', null)).to.deep.equal({
	data: { colors: ['BLUE', 'GREEN', 'RED'] },
	});
	});

[leebyron]

I'm not sure this is something we want to do - this is supposed to act as both an example of and full integration test of the schema definition API and query path.

[leebyron]

These are intended to be full integration tests, so they intentionally were running the full graphql function instead of just the execute step

[IvanGoncharov]

@leebyron it's a naming issue executeQuery is defined like this:

function executeQuery(query, variableValues) {
  return graphql(StarWarsSchema, query, new Query(), null, variableValues);
}

Since now in majority of tests you need to supply 3 args instead of 2:

const result = graphql(StarWarsSchema, query, new Query());

I decided to move it into utility function but now I see that it needs a better name. Do you have any suggestions?

[leebyron]

I prefer without the Data suffix for readability

[langpavel]

No please, because of:

graphql-js/src/__tests__/starWarsSchema.js

Line 12 in eef0878

import type { CharacterData, HumanData, DroidData } from './starWarsData';

[IvanGoncharov]

I'm not sure this is something we want to do - this is supposed to act as both an example of and full integration test of the schema definition API and query path.

@leebyron Agree 👍 I got carried away with shiny SDL syntax, GraphQL*Type is still a backbone of this library. At the same time, we need a more complex example of SDL defined schema than this one: https://graphql.org/graphql-js/object-types/
How about adding separate starWarsSDLSchema.js alongside with starWarsSchema.js?

P.S. This PR is not a part of 14.0.0 so I will postpone this PR until we ship release.

[guxima]

so these codes for v15??

[yaacovCR]

Closing this old PR, feel free to reopen!

We can track efforts to build a makeExecutableSchema() type approach in #3047