fix: deprecated reason non-nullable#735
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the built-in GraphQL meta-schema to align with the updated GraphQL spec by making the @deprecated directive’s reason argument non-nullable (while retaining its default), and adjusts introspection test expectations accordingly.
Changes:
- Change
@deprecated(reason: ...)argument type fromStringtoString!in the internal meta-schema. - Update introspection test expected JSON to reflect
reasonasNON_NULLwrappingString.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/schema/meta.go | Updates the meta-schema definition of @deprecated so reason is String! with the same default. |
| graphql_test.go | Updates introspection expectations to match the new non-null type structure for reason. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavelnikolov
force-pushed
the
deprecated-arg-non-null
branch
from
7ad65dc to
6c596ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the reason for deprecation non-nullable to match the spec graphql/graphql-spec#1040.