chore: modernize CI workflow, bump dependencies, and clean up reflect usage#313
Merged
Merged
Conversation
- switch trigger branch from master to main - add minimum permissions (contents: read) - add concurrency group to cancel superseded runs - pin actions to SHA with version comments - pin golangci-lint to v2.12.2 - add build target to Makefile and run via make build - enable -race in make test
- gqlgen v0.17.73 -> v0.17.91
- gqlparser v2.5.26 -> v2.5.34
- goccy/go-yaml v1.17.1 -> v1.19.2
- testify v1.10.0 -> v1.11.1
- golang.org/x/{text,tools,mod,sync} updates
- split go directive: go 1.26 + toolchain go1.26.4
- replace reflect.Ptr with reflect.Pointer (Go 1.18+ recommended alias) - regenerate example clients with gqlgen v0.17.91 - NewClient now takes clientv2.HttpClient instead of *http.Client - nullable fields emitted as pointer + omitempty - remove newof helper in example/files-info; use &val directly
- move GenGettersGenerator.returnTypeName after exported methods (funcorder) - reformat imports with gci in clientgenv2/template.go, querydocument and generator testdata - drop trailing newline in query_document_test.go (whitespace)
osamingo
marked this pull request as ready for review
June 15, 2026 09:46
Contributor
Author
|
@Yamashou Hi, Cloud you review this PR, if you have a time.:) |
Contributor
Author
|
@Yamashou Could you merge this PR? (I haven't any permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, add minimum permissions and concurrency group, pin actions to commit SHAs with version comments, and unify Go commands behind theMakefile.gqlgen,gqlparser,goccy/go-yaml,testify,golang.org/x/*); split thegodirective intogo 1.26+toolchain go1.26.4.reflect.Ptrwith the recommendedreflect.Pointeralias, regenerate example clients withgqlgen v0.17.91, and drop the unusednewofhelper inexample/files-infoin favor of&val.golangci-linttov2.12.2.Changes
CI / Makefile
master→main.permissions: contents: readand aconcurrencygroup that cancels superseded runs.golangci-linttov2.12.2.buildtarget toMakefileand call it from CI asmake build.-raceinmake test.Dependencies
gqlgenv0.17.73 → v0.17.91gqlparserv2.5.26 → v2.5.34goccy/go-yamlv1.17.1 → v1.19.2testifyv1.10.0 → v1.11.1golang.org/x/{text,tools,mod,sync}updatesgo 1.26.2→go 1.26+toolchain go1.26.4Refactor
reflect.Ptr→reflect.Pointerinclientv2/client.goandgraphqljson/graphql.go.gqlgen:NewClientnow takesclientv2.HttpClientinstead of*http.Client; nullable fields are emitted as pointer +omitempty.newofhelper inexample/files-info/main.go; use&uFiledirectly.Lint fixes
GenGettersGenerator.returnTypeNameafter exported methods (funcorder).gciinclientgenv2/template.go,querydocument/query_document_test.go, andgenerator/testdata/nullable_input_omittable/e2e_test.go.querydocument/query_document_test.go(whitespace).Test plan
make buildpasses locally.make test(with-race) passes locally.