Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

Day-of-week parse support for MON-SUN (or 1-7) #27

Description

@stayclassychicago

cronexpr.Parse() correctly parses dow (day-of-week) when written as 0-6 or SUN-SAT – but does NOT correctly parse when written as MON-SUN or 1-7

We can see that 0 and 7 both resolve to Sunday, so it should be possible to write expressions as either 0-6 OR 1-7 and have the same result. However- the 1-7 day-of-week does not parse.

Here is an example / reproduction scenario

package main

import (
	"fmt"
	"time"

	"github.com/gorhill/cronexpr"
)

func main() {
	t := time.Date(2017, time.July, 18, 13, 47, 0, 0, time.UTC)

	for _, dow := range []string{"MON-SUN", "SUN-SAT", "0-6", "1-7"} {
		times := cronexpr.MustParse(fmt.Sprintf("* *  * * %s", dow)).NextN(t, 8)

		if len(times) == 0 {
			fmt.Printf("Could NOT parse [%s]\n", dow)
		} else {
			for i := range times {
				fmt.Println(times[i].Format(time.RFC1123))
			}
		}

	}

}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions