Skip to content

chore(bigframes): refactor "generate_bigframes_bigquery.py" #17904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sycai wants to merge 39 commits into
base: main
Choose a base branch
from
Open

chore(bigframes): refactor "generate_bigframes_bigquery.py" #17904

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
b7e5a06
checkpoint: add logic for rendering signature template
sycai Jul 26, 2026
cc3288e
checkpoint: impl operator definition gen
sycai Jul 26, 2026
8019f08
checkout: impl test generation
sycai Jul 26, 2026
310a93a
checkpoint: refactor arg rendering
sycai Jul 26, 2026
5ba9eb3
finish refactoring
sycai Jul 27, 2026
ab100cb
make old script still runnable
sycai Jul 27, 2026
f85141a
fix script reference
sycai Jul 27, 2026
0e6d04a
fix lint
sycai Jul 27, 2026
9353f35
Update packages/bigframes/scripts/bigquery_generator/__main__.py
sycai Jul 27, 2026
78041aa
Update packages/bigframes/scripts/bigquery_generator/file_generator.py
sycai Jul 27, 2026
4fd77b8
Update packages/bigframes/scripts/bigquery_generator/file_generator.py
sycai Jul 27, 2026
aa24eb9
Update packages/bigframes/scripts/bigquery_generator/file_generator.py
sycai Jul 27, 2026
393010b
Update packages/bigframes/scripts/bigquery_generator/template_rendere…
sycai Jul 27, 2026
f1fea76
Update packages/bigframes/scripts/bigquery_generator/yaml_parser.py
sycai Jul 27, 2026
70e9091
Update packages/bigframes/scripts/bigquery_generator/yaml_parser.py
sycai Jul 27, 2026
e1b8a37
Update packages/bigframes/scripts/bigquery_generator/yaml_parser.py
sycai Jul 27, 2026
aa1b51b
Update packages/bigframes/scripts/generate_bigframes_bigquery.py
sycai Jul 27, 2026
aa74300
Update packages/bigframes/scripts/bigquery_generator/template_rendere…
sycai Jul 27, 2026
dcbd2ea
Update packages/bigframes/scripts/bigquery_generator/template_rendere…
sycai Jul 27, 2026
a048b0c
fix lint
sycai Jul 27, 2026
e3fb8fd
fix import
sycai Jul 27, 2026
3049a97
fix format
sycai Jul 27, 2026
83b22f0
fix lint
sycai Jul 27, 2026
4653ca0
Merge branch 'main' into sycai_generator_refactor
sycai Jul 27, 2026
0eb0aef
Merge branch 'main' into sycai_generator_refactor
sycai Jul 28, 2026
ddc6d4c
update script path
sycai Jul 28, 2026
8ef98b9
remove __main__.py from package
sycai Jul 28, 2026
bd136c6
update template loading and module-level docstrings
sycai Jul 28, 2026
9ea30b8
fix format
sycai Jul 28, 2026
844ffb8
Merge branch 'main' into sycai_generator_refactor
sycai Jul 29, 2026
2a4e432
Merge branch 'main' into sycai_generator_refactor
sycai Jul 29, 2026
404a8ce
update branch to keep up with main
sycai Jul 29, 2026
844f444
simplify IR during yaml loading phase
sycai Jul 29, 2026
7909506
reduce the size of constants.py
sycai Jul 29, 2026
1a8d53c
update IR and jinja templates
sycai Jul 29, 2026
d8cb52f
refactor type checking and add examples in template_renderer
sycai Jul 29, 2026
c20ada7
make data classes immutable and polish logics
sycai Jul 30, 2026
5313842
fix type hints
sycai Jul 30, 2026
1ec747e
polish docstrings
sycai Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/bigframes/bigframes/extensions/bigframes/series_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated by the script: scripts/generate_bigframes_bigquery.py
# This file was generated by the script: scripts/bigquery_generator
#

from __future__ import annotations
Expand Down Expand Up @@ -44,17 +44,17 @@ def _to_dataframe(self, bf_df: dataframe.DataFrame) -> T:
def _to_series(self, bf_series: series.Series) -> S:
return cast(S, bf_series)

@property
def ai(self) -> BigframesAiSeriesAccessor[T, S]:
return BigframesAiSeriesAccessor(self._obj)

@property
def aead(self) -> BigframesAeadSeriesAccessor[T, S]:
return BigframesAeadSeriesAccessor(self._obj)

@property
def ai(self) -> BigframesAiSeriesAccessor[T, S]:
return BigframesAiSeriesAccessor(self._obj)


@log_adapter.class_logger
class BigframesAiSeriesAccessor(core_accessor.AiSeriesAccessor[T, S]):
class BigframesAeadSeriesAccessor(core_accessor.AeadSeriesAccessor[T, S]):
def __init__(self, bf_obj: S):
super().__init__(bf_obj)

Expand All @@ -71,7 +71,7 @@ def _to_series(self, bf_series: series.Series) -> S:


@log_adapter.class_logger
class BigframesAeadSeriesAccessor(core_accessor.AeadSeriesAccessor[T, S]):
class BigframesAiSeriesAccessor(core_accessor.AiSeriesAccessor[T, S]):
def __init__(self, bf_obj: S):
super().__init__(bf_obj)

Expand Down
18 changes: 9 additions & 9 deletions packages/bigframes/bigframes/extensions/core/series_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated by the script: scripts/generate_bigframes_bigquery.py
# This file was generated by the script: scripts/bigquery_generator
#

from __future__ import annotations
Expand Down Expand Up @@ -44,13 +44,13 @@ class BigQuerySeriesAccessor(

@property
@abc.abstractmethod
def ai(self) -> AiSeriesAccessor[T, S]:
"""Accessor for BigQuery ai functions."""
def aead(self) -> AeadSeriesAccessor[T, S]:
"""Accessor for BigQuery aead functions."""

@property
@abc.abstractmethod
def aead(self) -> AeadSeriesAccessor[T, S]:
"""Accessor for BigQuery aead functions."""
def ai(self) -> AiSeriesAccessor[T, S]:
"""Accessor for BigQuery ai functions."""

def deterministic_decrypt_bytes(
self,
Expand Down Expand Up @@ -1112,10 +1112,6 @@ def unix_date(
return self._to_series(cast(series.Series, result))


class AiSeriesAccessor(series_tvf_mixins.AITVFMixin[T, S]):
"""Series accessor for BigQuery ai functions."""


class AeadSeriesAccessor(abstract_series_accessor.AbstractBigQuerySeriesAccessor[T, S]):
"""Series accessor for BigQuery aead functions."""

Expand Down Expand Up @@ -1227,3 +1223,7 @@ def encrypt(
additional_data,
)
return self._to_series(cast(series.Series, result))


class AiSeriesAccessor(series_tvf_mixins.AITVFMixin[T, S]):
"""Series accessor for BigQuery ai functions."""
14 changes: 7 additions & 7 deletions packages/bigframes/bigframes/extensions/pandas/series_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated by the script: scripts/generate_bigframes_bigquery.py
# This file was generated by the script: scripts/bigquery_generator
#

from __future__ import annotations
Expand Down Expand Up @@ -51,17 +51,17 @@ def _to_dataframe(self, bf_df: dataframe.DataFrame) -> T:
def _to_series(self, bf_series: series.Series) -> S:
return cast(S, bf_series.to_pandas(ordered=True))

@property
def ai(self) -> PandasAiSeriesAccessor[T, S]:
return PandasAiSeriesAccessor(self._obj)

@property
def aead(self) -> PandasAeadSeriesAccessor[T, S]:
return PandasAeadSeriesAccessor(self._obj)

@property
def ai(self) -> PandasAiSeriesAccessor[T, S]:
return PandasAiSeriesAccessor(self._obj)


@log_adapter.class_logger
class PandasAiSeriesAccessor(core_accessor.AiSeriesAccessor[T, S]):
class PandasAeadSeriesAccessor(core_accessor.AeadSeriesAccessor[T, S]):
def __init__(self, pandas_obj: S):
super().__init__(pandas_obj)

Expand All @@ -80,7 +80,7 @@ def _to_series(self, bf_series: series.Series) -> S:


@log_adapter.class_logger
class PandasAeadSeriesAccessor(core_accessor.AeadSeriesAccessor[T, S]):
class PandasAiSeriesAccessor(core_accessor.AiSeriesAccessor[T, S]):
def __init__(self, pandas_obj: S):
super().__init__(pandas_obj)

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/aead.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/aead.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/global_namespace/aead_encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/global_namespace/aead_encryption.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/global_namespace/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/global_namespace/array.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/global_namespace/bit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/global_namespace/bit.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/global_namespace/conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/global_namespace/conversion.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/operations/googlesql/global_namespace/date.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# DO NOT MODIFY THIS FILE DIRECTLY.
# This file was generated from: scripts/data/sql-functions/global_namespace/date.yaml
# by the script: scripts/generate_bigframes_bigquery.py
# by the script: scripts/bigquery_generator

from __future__ import annotations

Expand Down
13 changes: 13 additions & 0 deletions packages/bigframes/scripts/bigquery_generator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
31 changes: 31 additions & 0 deletions packages/bigframes/scripts/bigquery_generator/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


@tswast tswast Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the main entrypoint for the script, please include instructions on how to run it in a docstring.

Optionally, when run with -h or --help, also display this newly created docstring.

@sycai sycai Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed. I will make this package un-executable on its own.

import constants
import file_generator
import yaml_parser
Comment thread
sycai marked this conversation as resolved.
Outdated


def main():
modules = []

for yaml_file in sorted(constants.DATA_DIR.glob("**/*.yaml")):
modules.append(yaml_parser.parse_yaml(yaml_file))

file_generator.generate(modules)


if __name__ == "__main__":
main()
Loading
Loading