-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(generator): delegate REST transcoding to google-api-core #17766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hebaalazzeh
wants to merge
17
commits into
main
Choose a base branch
from
feat/gapic-generator-centralization-transcoding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
215e7d3
feat(generator): delegate REST transcoding to google-api-core
hebaalazzeh 2d5c5ca
fix(generator): use unified _compat.py.j2 and remove downstream tests
hebaalazzeh 378db6a
ci: re-trigger checks for PR 17766
hebaalazzeh f93d358
chore(generator): remove generated_showcase from repository
hebaalazzeh d853b3c
fix(generator): install local google-api-core in nox test sessions
hebaalazzeh 50a02e4
fix(generator): add type ignores to _compat.py and reinstall local go…
hebaalazzeh 02c9150
style(generator): replace pass with docstring in _rest_mixins_base.py.j2
hebaalazzeh 50f88ed
fix(generator): filter bound path and body fields from required field…
hebaalazzeh 578be4b
fix(generator): use mangled name for required fields default values a…
hebaalazzeh 04acb10
feat(templates): add generated _compat.py across integration test gol…
hebaalazzeh b24213c
feat(templates): update generated client code across integration test…
hebaalazzeh 94d1307
fix(generator): remove local google-api-core relative path install fr…
hebaalazzeh daf41d2
revert changes
hebaalazzeh 6d8ab2e
Merge branch 'main' into feat/gapic-generator-centralization-transcoding
hebaalazzeh b88ee31
update goldens
hebaalazzeh 35d1a08
update goldens
hebaalazzeh 22910f3
update goldens
hebaalazzeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.