Skip to content

feat(datastore): split gapic and proto usage from the handwritten library into datastore-api - #8938

Merged
quirogas merged 4 commits into
mainfrom
feywind-split-datastore
Jul 27, 2026
Merged

feat(datastore): split gapic and proto usage from the handwritten library into datastore-api#8938
quirogas merged 4 commits into
mainfrom
feywind-split-datastore

Conversation

@feywind

@feywind feywind commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This is in the effort to remove OwlBot from the standard repo path. A new package (datastore-api) takes care of what OwlBot used to do (shuffle in new protos and generated gapic classes).

Internal: b/531788771

@product-auto-label product-auto-label Bot added the api: datastore Issues related to the Datastore API. label Jul 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes locally generated GAPIC clients and proto files, replacing them with a dependency on @google-cloud/datastore-api. It updates dependencies, build scripts, imports, and mock servers to use this new package. Feedback was provided regarding the resolution of package.json via require.resolve in datastore-server.ts, which may fail in modern Node.js environments with strict exports; resolving the main entry point instead is recommended.

Comment thread handwritten/datastore/mock-server/datastore-server.ts Outdated
@feywind
feywind marked this pull request as ready for review July 24, 2026 19:20
@feywind
feywind requested a review from a team as a code owner July 24, 2026 19:20
@quirogas
quirogas merged commit 182bda2 into main Jul 27, 2026
35 checks passed
@quirogas
quirogas deleted the feywind-split-datastore branch July 27, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants