test(firestore): kokoro to gcb - #8937
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a Cloud Build configuration file (cloudbuild.yaml) under handwritten/firestore to automate dependency installation, system test execution, and optional code coverage reporting. There are no review comments, and I have no feedback to provide.
… firestore-enterprise named databases
…t index management
…json for test index management
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
|
This is looking good, but I would also suggest that we just skip the small number of tests that seem to be failing shown in https://paste.googleplex.com/4859917847625728. The GCB check will be a lot more reliable if we can expect it to pass under normal circumstances. |
…b.com/googleapis/google-cloud-node into markduckworth/kokoro-to-gcb-firestore
Contributor
Author
|
/gcbrun |
danieljbruce
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues in #8700.
Because Datastore SDK tests also run against Firestore database instances (in Datastore mode) within long-door-651, naming collisions occur between the database instances used for Firestore and Datastore tests. To resolve this, Firestore CI will utilize uniquely named databases: firestore-standard and firestore-enterprise
We can merge this PR, or merge this branch to
kokoro-to-gcb-firestore, and then merge #8700.