Skip to content

chore(ci): update expected flattened dependencies - #13938

Merged
whowes merged 1 commit into
mainfrom
whowes/flattened-deps
Jul 30, 2026
Merged

chore(ci): update expected flattened dependencies#13938
whowes merged 1 commit into
mainfrom
whowes/flattened-deps

Conversation

@whowes

@whowes whowes commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The "java-shared-config downstream (dependencies) / flatten-plugin-check" is currently failing on release PR #13934

It passes on this PR that updates kokoro/java-storage-expected-flattened-dependencies.txt, accounting for recent version changes (#13693, #13799, #13842, #13853, #13854, #13875, #13876, #13877).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various dependency versions in the .kokoro/java-storage-expected-flattened-dependencies.txt file, including updates to Google Cloud Storage, GRPC, Guava, Protobuf, and Conscrypt libraries. I have no feedback to provide as there are no review comments.

@whowes
whowes force-pushed the whowes/flattened-deps branch 2 times, most recently from f28aa8a to cca5a14 Compare July 28, 2026 22:49
@whowes
whowes marked this pull request as ready for review July 28, 2026 23:09
@whowes
whowes requested review from a team as code owners July 28, 2026 23:09
@whowes
whowes requested a review from lqiu96 July 28, 2026 23:09
@whowes
whowes marked this pull request as draft July 29, 2026 19:47
@whowes
whowes force-pushed the whowes/flattened-deps branch 4 times, most recently from 6d537f0 to 8a36a8d Compare July 29, 2026 21:03
@whowes
whowes force-pushed the whowes/flattened-deps branch from 8a36a8d to 7095858 Compare July 29, 2026 21:06
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@whowes
whowes marked this pull request as ready for review July 29, 2026 21:39
@whowes
whowes requested a review from blakeli0 July 29, 2026 21:39

@blakeli0 blakeli0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should evaluate if this check still provides value. IIRC, there was a bug in the flatten plugin, so it was created to test the flatten plugin. But we should not test our build dependencies, the same as that we don't test other Maven plugins such as maven deploy or formatter.

@whowes
whowes merged commit 81cf71c into main Jul 30, 2026
202 checks passed
@whowes
whowes deleted the whowes/flattened-deps branch July 30, 2026 16:15
@whowes whowes added the release-please:force-run To run release-please label Jul 30, 2026
@release-please release-please Bot removed the release-please:force-run To run release-please label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants