Propagate fetch body read errors through pipe streams - #1499
Open
Hashim1999164 wants to merge 1 commit into
Open
Propagate fetch body read errors through pipe streams#1499Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Wrap responseToReadable reader.read() in try/catch and destroy the Readable with the error so fetch().pipe no longer leaves unhandled promise rejections when the response stream fails. Fixes google#1443.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
responseToReadableassigned an async_readhandler that awaitedreader.read()without a try/catch. When the response body failed (network drop, abort, corrupted stream), that became an unhandled promise rejection and could crash the Node process.This catches read failures and calls
rs.destroy(err)so the error flows through the piped stream instead.Fixes #1443
Test plan
reader.read()insrc/goods.tsfetch(url, { signal }).pipe\cat``, abort the signal mid-stream, and confirm the pipe rejects without an unhandledRejection