Skip to content

docs: fix tmpfile example comment - #1498

Open
islamhafez0 wants to merge 1 commit into
google:mainfrom
islamhafez0:fix/tmpfile-docs-comment
Open

docs: fix tmpfile example comment#1498
islamhafez0 wants to merge 1 commit into
google:mainfrom
islamhafez0:fix/tmpfile-docs-comment

Conversation

@islamhafez0

@islamhafez0 islamhafez0 commented Aug 6, 2026

Copy link
Copy Markdown

What

Fixes #1469. The docs example for mpfile() shows the wrong output filename.

Why

mpfile('f2.txt') returns path.join(tempdir(), 'f2.txt') (see src/goods.ts), so the resulting path ends in f2.txt, not foo.txt. The inline comment was misleading.

Checklist

  • Verified against src/goods.ts implementation

@google-cla

google-cla Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@islamhafez0

Copy link
Copy Markdown
Author

@googlebot I signed it!

@islamhafez0
islamhafez0 force-pushed the fix/tmpfile-docs-comment branch from 0e2233f to e221434 Compare August 6, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(api): tmpfile('f2.txt') example shows wrong output filename (foo.txt)

1 participant