Skip to content

[DO NOT MERGE] Opt-in sharded GRPO log-prob head: gather the vocab table once, scan local tokens (-11.8% step time, v7x 397B bench) #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parambole wants to merge 4 commits into from
Closed

[DO NOT MERGE] Opt-in sharded GRPO log-prob head: gather the vocab table once, scan local tokens (-11.8% step time, v7x 397B bench) #2873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a29991d
Add an opt-in sharded log-prob head for packed rows (TUNIX_LOGPS_SHAR…
parambole Oct 14, 2026
743646d
Fix the sharded log-prob head's docs and tests; same traced program
parambole Oct 14, 2026
1301c60
Correct two docstrings of the sharded log-prob head (Explicit-axis ra…
parambole Oct 14, 2026
6d2fb66
Forward TUNIX_LOGPS_SHARDED_HEAD to the trainer in k8s_launcher.sh
parambole Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/experimental/examples/deepswe_dist/mlperf_submission_launcher_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,19 @@ def test_dropless_rejects_other_values(self):
with self.assertRaisesRegex(AssertionError, "DROPLESS must be true or false"):
_render(DROPLESS="yes")

def test_the_sharded_log_prob_head_is_off_unless_set(self):
self.assertNotIn("TUNIX_LOGPS_SHARDED_HEAD", self.default)

def test_the_sharded_log_prob_head_reaches_the_trainer_only(self):
render = _render(TUNIX_LOGPS_SHARDED_HEAD="local")
self.assertRegex(
_jobset(render, "train"), r"\bTUNIX_LOGPS_SHARDED_HEAD=local\b"
)
for suffix in ("orch", "roll-0"):
self.assertNotIn(
"TUNIX_LOGPS_SHARDED_HEAD", _jobset(render, suffix), suffix
)

def test_default_batch_gives_the_gbs_1024_hyperparameters(self):
orch = _jobset(self.default, "orch")
self.assertIn("--batch_size=64 ", orch)
Expand Down
Loading
Loading