Disable the profiler on an empty profiling window instead of raising - #2088
Open
gutianyu-google wants to merge 1 commit into
Open
Disable the profiler on an empty profiling window instead of raising#2088gutianyu-google wants to merge 1 commit into
gutianyu-google wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`Profiler.__init__` raised ValueError when the first profile step was not before the last one. That window is derived from the trainer's initial and max steps plus the profiler options, and in RL setups the PeftTrainer is constructed with initial_step == max_step, so any profiler_options at all aborted the run at construction time, well after the models had loaded. An empty profiling window is a misconfiguration of profiling, not of the training run. Warn with the derived step numbers and disable profiling, matching how the profiler already behaves without options or on a non-primary process.
gutianyu-google
force-pushed
the
sft-profiler-fail-open
branch
from
September 2, 2026 21:00
14e9283 to
9e86934
Compare
gutianyu-google
marked this pull request as ready for review
September 3, 2026 01:23
gutianyu-google
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
September 3, 2026 01:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiler.__init__raisedValueErrorwhen the first profile step was not before the last one. That window is derived from the trainer'sinitial_stepandmax_stepplus the profiler options, and in RL setups thePeftTraineris constructed withinitial_step == max_step, so passing anyprofiler_optionsat all aborted the run at trainer construction, well after the models had loaded onto the accelerators.An empty profiling window is a misconfiguration of profiling, not of the training run. This PR warns with the derived step numbers and disables profiling for that instance, matching how the profiler already behaves when no options are given or on a non-primary process. Valid windows are unaffected.
The existing
test_invalid_step_numberscases are kept and now assert the warning, the disabled state, and thatmaybe_activatedoes not start a trace.Checklist