Add optional trajectory_ids filtering to TrajectoryStore.get_trajectories_metadata across store implementations: - #2056
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add optional trajectory_ids filtering to TrajectoryStore.get_trajectories_metadata across store implementations:#2056copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
August 31, 2026 21:35
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_974081436
branch
from
August 31, 2026 21:56
5efac76 to
67e7f86
Compare
copybara-service
Bot
force-pushed
the
test_974081436
branch
from
August 31, 2026 22:19
67e7f86 to
1226ccb
Compare
copybara-service
Bot
force-pushed
the
test_974081436
branch
6 times, most recently
from
September 2, 2026 05:10
b089538 to
98331e2
Compare
copybara-service
Bot
force-pushed
the
test_974081436
branch
5 times, most recently
from
September 2, 2026 20:09
b927b45 to
228b97a
Compare
…ries_metadata across store implementations: - TrajectoryReader Protocol: Update protocol signature in `store.py` to accept `trajectory_ids: list[str] | None = None` and document `TrajectoryMetadataNotFoundError` when requested IDs are missing. - FileTrajectoryStore: Support filtering metadata by explicit trajectory IDs, preserving request order and raising `TrajectoryMetadataNotFoundError` if any requested ID does not exist or has missing metadata on disk. - InMemoryTrajectoryStore: Support filtering metadata by trajectory_ids, returning deep copies of matched metadata or raising `TrajectoryMetadataNotFoundError` for missing IDs. Tests Added: - store_testing: Add reusable contract tests to `TrajectoryReaderTestCase` covering ID filtering, missing ID error handling, and empty list retrieval. PiperOrigin-RevId: 974081436
copybara-service
Bot
force-pushed
the
test_974081436
branch
from
September 2, 2026 20:18
228b97a to
b762f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional trajectory_ids filtering to TrajectoryStore.get_trajectories_metadata across store implementations:
store.pyto accepttrajectory_ids: list[str] | None = Noneand documentTrajectoryMetadataNotFoundErrorwhen requested IDs are missing.TrajectoryMetadataNotFoundErrorif any requested ID does not exist or has missing metadata on disk.TrajectoryMetadataNotFoundErrorfor missing IDs.Tests Added:
TrajectoryReaderTestCasecovering ID filtering, missing ID error handling, and empty list retrieval.