Skip to content

Add TODO, construct the WeightSynchronizer inside the trainer #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TODO, construct the WeightSynchronizer inside the trainer #1958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tunix/experimental/train/peft_trainer_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ def _default_weight_sync_worker() -> Any:
host_stage="proxy" in os.environ.get("JAX_PLATFORMS", ""),
)

# TODO: Construct the use the training config to control PW or McJax

class PeftTrainer(abstract_trainer.AbstractTrainer):
"""PEFT trainer for LoRA. Only LoRA parameters are updated.
Expand Down
Loading