Update Protos - #92
Closed
s2t2 wants to merge 1 commit into
Closed
Conversation
s2t2
added a commit
that referenced
this pull request
Jun 6, 2025
s2t2
marked this pull request as ready for review
June 6, 2025 14:49
Collaborator
Author
|
@JudahGoldfeder let me know if these updated Protos look good to you. If everything is good, we can plan to merge this PR after #93 . |
s2t2
added a commit
that referenced
this pull request
Jun 12, 2025
2 tasks
ajkhabbazi
added a commit
to ajkhabbazi/sbsim
that referenced
this pull request
Aug 7, 2026
The protobuf runtime bump to ^4.25.0 is incompatible with the legacy gencode checked into the repo, which fails at import with "Descriptors cannot be created directly". Regenerate the three pb2.py files with protoc 3.21.12, matching the version installed by CI on Linux and Mac and documented in docs/setup/mac.md. The output is identical to that of google#92. Also switch the Dockerfile to the apt-installed protoc rather than grpc_tools.protoc, which bundled 4.25.x and so generated different output inside the container than every other environment. This requires libprotobuf-dev for the well-known types, which --no-install-recommends had excluded. grpcio-tools is no longer needed and is dropped.
s2t2
pushed a commit
that referenced
this pull request
Aug 20, 2026
Fixes #80 Supersedes and Closes #111 (carries @igopalakrishna's original work forward). Commits: * feat: Optimize Dockerfile and update setup documentation * Switch to python:3.11-slim base image and fix deps - Replace Ubuntu 20.04 + deadsnakes with python:3.11-slim - Update protobuf to ^4.25.0 (TF 2.15.1 compatible) - Update grpcio-tools to ^1.60.0 - Regenerate protobuf files for protobuf 4.x compatibility - Add Apple Silicon notes to Docker docs - Regenerate poetry.lock * Regenerate protos with pinned protoc 3.21.12 The protobuf runtime bump to ^4.25.0 is incompatible with the legacy gencode checked into the repo, which fails at import with "Descriptors cannot be created directly". Regenerate the three pb2.py files with protoc 3.21.12, matching the version installed by CI on Linux and Mac and documented in docs/setup/mac.md. The output is identical to that of #92. Also switch the Dockerfile to the apt-installed protoc rather than grpc_tools.protoc, which bundled 4.25.x and so generated different output inside the container than every other environment. This requires libprotobuf-dev for the well-known types, which --no-install-recommends had excluded. grpcio-tools is no longer needed and is dropped. --------- Co-authored-by: Gopala Krishna <gopala.krishna.abba@gmail.com>
Collaborator
Author
|
Closing because #80 has updated the protos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate protos using libprotoc 3.21.12.
To minimize differences in setups, we are pinning a specific version of protoc. The latest version of protoc installed on Linux machines is 3.21.12 (the chosen version). The latest version installed on Mac via homebrew is 3.29 (however this is ahead of the linux installation). It is unclear which version was used to generate the current protos.