Update ja_Jpan.textproto - #10735
Open
aaronbell wants to merge 1 commit into
Open
Conversation
Updating Japanese text strings to ensure that Kanji and Kana are present for Noto fonts
Collaborator
Author
|
@simoncozens Referencing your old Japanese font audit (#7056) I'm updating the strings for Japanese to include both Kana and Kanji. LMK if you'd suggest other strings. |
Collaborator
|
I don't understand this change - both before and after samples contain kana and kanji. |
Collaborator
Author
|
@simoncozens If you look at https://fonts.google.com/noto/specimen/Noto+Sans+JP?preview.layout=grid, the top specimen only shows Hiragana "すべての". So this change is making sure there is Kanji & Kana present in the first 4 characters to ensure the top specimen shows both in all scenarios. |
Collaborator
|
Only problem now is that changes to lang should be made in googlefonts/lang (which gets imported into here). But I can make the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Japanese text strings to ensure that Kanji and Kana are present for Noto fonts