fix: mitigate unauthenticated path traversal in genmedia SPA routing#2214
Open
AK47Kavan wants to merge 1 commit into
Open
fix: mitigate unauthenticated path traversal in genmedia SPA routing#2214AK47Kavan wants to merge 1 commit into
AK47Kavan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2201
Description
This PR resolves the unauthenticated path traversal vulnerability reported in issue #2201 within the
genmedia-for-commerceapplication routing.Changes
pathlib.Path.resolve().safe_path.is_relative_to(resolved_frontend_dir)check to ensure that the resolved asset path cannot traverse outside the boundary of the designated frontend assets directory.403 ForbiddenJSON response if a path traversal attempt is detected.Verification
../../) are safely caught and rejected by the validation step.