Skip to content

fix(gcsartifact): prevent artifact version race in concurrent Save #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wolo-lab wants to merge 1 commit into
base: main
Choose a base branch
from
+397 −87
Open

fix(gcsartifact): prevent artifact version race in concurrent Save #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions artifact/gcsartifact/gcs_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ type gcsObject interface {
newReader(ctx context.Context) (io.ReadCloser, error)
delete(ctx context.Context) error
attrs(ctx context.Context) (*storage.ObjectAttrs, error)
// ifNotExist returns a handle whose write succeeds only if the object does
// not already exist; writing over an existing object fails with HTTP 412.
ifNotExist() gcsObject
}

// gcsObjectIterator
Expand Down Expand Up @@ -97,6 +100,11 @@ func (w *gcsObjectWrapper) newWriter(ctx context.Context) gcsWriter {
return &gcsWriterWrapper{w: w.object.NewWriter(ctx)}
}

// ifNotExist implements the gcsObject interface for gcsObjectWrapper.
func (w *gcsObjectWrapper) ifNotExist() gcsObject {
return &gcsObjectWrapper{object: w.object.If(storage.Conditions{DoesNotExist: true})}
}

// NewReader implements the gcsObject interface for gcsObjectWrapper.
func (w *gcsObjectWrapper) newReader(ctx context.Context) (io.ReadCloser, error) {
return w.object.NewReader(ctx)
Expand Down
Loading
Loading