test(artifact): cover GetArtifactVersion#1156
Open
mdabydeen wants to merge 1 commit into
Open
Conversation
Exercise latest and explicit-version metadata retrieval, including missing-version and missing-file cases, through the shared artifact service suite. The test-only changes run against both in-memory and mocked GCS implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
GetArtifactVersionon the shared artifact service test suite had no direct test coverage for retrieving the latest version, an explicit version, or the not-found paths for a missing version/file.Solution:
Add a
testArtifactService_GetArtifactVersionsub-test tointernal/artifact/tests/service_suite.gothat saves three versions of an artifact and exercisesGetArtifactVersionfor the latest version, an explicit version, a nonexistent version, and a nonexistent file, assertingfs.ErrNotExistfor the not-found cases. This runs against both the in-memory and mocked GCS implementations via the shared suite. Also extended the existing empty-service test with aGetArtifactVersionnot-found case.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
N/A — test-only change to the shared artifact service test suite.
Checklist
Additional context
N/A