feat: support multi-module Go development in CI and update developer documentation#1155
Open
hanorik wants to merge 1 commit into
Open
feat: support multi-module Go development in CI and update developer documentation#1155hanorik wants to merge 1 commit into
hanorik wants to merge 1 commit into
Conversation
wolo-lab
previously approved these changes
Jul 16, 2026
wolo-lab
left a comment
wolo-lab
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One comment from my side.
Please wait for the approval from Hana.
wolo-lab
previously approved these changes
Jul 16, 2026
hyangah
reviewed
Jul 17, 2026
karolpiotrowicz
left a comment
karolpiotrowicz
left a comment
Contributor
There was a problem hiding this comment.
The "Multi-Module Development" section is duplicated verbatim between AGENTS.md and CONTRIBUTING.md, and the two copies have already drifted (step 7 differs: go build work in AGENTS.md vs go build ./... in CONTRIBUTING.md). To keep them from diverging further, could we keep a single source of truth — e.g. CONTRIBUTING.md owns the section and AGENTS.md links to it (or vice-versa)? That way there's only one place to update when the workflow changes.
A couple of specific inline notes below.
hanorik
force-pushed
the
ci_enhancement
branch
2 times, most recently
from
July 20, 2026 10:41
0026d56 to
f28df9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR transitions the repository to a multi-module workspace to prevent heavy/optional dependencies from bloating the core ADK module.
Key Changes:
.github/workflowsto dynamically discover allgo.modfiles and run tests, linters, andgovulncheckindependently via matrix strategies.go.modfrom accidentally importing internal submodules.CONTRIBUTING.mdandAGENTS.md.Testing Plan: