Skip to content

fix: prevent HITL confirmation replay#1120

Open
huynhtrungcip wants to merge 1 commit into
google:mainfrom
huynhtrungcip:fix-hitl-confirmation-replay
Open

fix: prevent HITL confirmation replay#1120
huynhtrungcip wants to merge 1 commit into
google:mainfrom
huynhtrungcip:fix-hitl-confirmation-replay

Conversation

@huynhtrungcip

Copy link
Copy Markdown

Summary:

  • Treat a HITL confirmation as already consumed when the original tool call has a response between the confirmation request and the current confirmation response.
  • Add processor-level coverage for replayed confirmations.
  • Add REST coverage that verifies replaying the same confirmation ID with a changed payload does not re-execute the tool.

Tests:

  • go test ./internal/llminternal -run TestRequestConfirmationRequestProcessor -count=1 -v
  • go test ./server/adkrest -run TestRESTHITLConfirmationReplayDoesNotReexecuteTool -count=1 -v
  • go test ./internal/llminternal ./server/adkrest -count=1
  • go test ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant