Preserve table signature when constructing tables from checkpoint protos - #158
Draft
rootkiller6788 wants to merge 1 commit into
Draft
Conversation
server_from_proto.tables_from_proto ignored the signature field of PriorityTableCheckpoint, so a table rebuilt from a checkpoint proto lost its signature. Decode the signature with nested_structure_coder and pass it to reverb.Table, matching how the C++ checkpoint path restores it. Add a regression test verifying the signature round-trips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
server_from_proto.tables_from_protoreconstructsreverb.Tableobjects fromPriorityTableCheckpointprotos but never passed thesignaturefield toreverb.Table.PriorityTableCheckpoint.signatureis atensorflow.StructuredValue(field 9 inreverb/cc/checkpointing/checkpoint.proto) that the C++Table::Checkpoint()writes andTable::InitializeFromCheckpoint()restores. The Python path dropped it, so any table rebuilt from a checkpoint proto lost its signature.A signature-less table means
TrajectoryDataset.from_table_signatureandClient.sample(..., unpack_as_table_signature=True)can no longer reconstruct the nested data structure, andTable.info().signaturereturnsNone.Fix
Decode
config.signaturewithtensorflow.python.saved_model.nested_structure_coder.decode_proto(the same codecTableInfo.from_serialized_protouses) and pass the result toreverb.Table(signature=...). When the field is unset,signature=Nonepreserves the previous behavior.Test
Added
ServerFromProtoTest.test_table_from_proto_preserves_signature, which encodes atf.TensorSpecsignature into aPriorityTableCheckpoint, converts it viatables_from_proto, and assertstables[0].info.signatureequals the original signature.