Skip to content

feat: timeout argument for client.sample #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varshneydevansh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: timeout argument for client.sample #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a1dd6
feat: timeout argument for client.sample
varshneydevansh Aug 23, 2023
a138193
corrected with the if-clause
varshneydevansh Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions reverb/cc/sampler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ class GrpcSamplerWorker : public SamplerWorker {
}
context_ = std::make_unique<grpc::ClientContext>();
context_->set_wait_for_ready(false);

if (rate_limiter_timeout != absl::InfiniteDuration()) {
// Buffer time to account for connection overhead
constexpr auto CONNECTION_BUFFER_TIME = std::chrono::milliseconds(200);
// Setting the deadline for the gRPC context
context_->set_deadline(absl::ToChronoTime(absl::Now() + rate_limiter_timeout + CONNECTION_BUFFER_TIME));
}

stream = stub_->SampleStream(context_.get());
}

Expand Down