doc: before-requesting-review checklist (AGENTS.md + ErdosProblems README)#4378
Draft
williamjblair wants to merge 3 commits into
Draft
doc: before-requesting-review checklist (AGENTS.md + ErdosProblems README)#4378williamjblair wants to merge 3 commits into
williamjblair wants to merge 3 commits into
Conversation
|
👋 This is an automated welcome message. 🤖 A few friendly reminders while the review gets started:
Thanks again for helping improve Formal Conjectures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts the recurring review corrections into the two files authors and their agents already read:
AGENTS.md: two rules that come up in review but weren't written anywhere: searchFormalConjecturesForMathliband neighboring files before defining anything (ErdosProblems: add 199, 224, 226, 246, 296, 363 (#3998 sync) #4343, ErdosProblems: add 31, 34, 47, 280 (#3998 sync) #4345), and keep notes-to-reviewers in the PR description rather than the Lean file (feat(ErdosProblems): add 755 #4036). Added to the existing Quality Checklist and DON'T list.FormalConjectures/ErdosProblems/README.md: a "Before requesting review" section with the Erdős-specific items (verbatim docstrings and solution attributions, ErdosProblems: formalise 11 solved problems, linking plby/lean-proofs #4319), following the pattern of the naming and docstring conventions already in that file.Every line traces to a real review comment on a merged PR. Doc-only; follows up on the Zulip discussion about making the repetitive half of review a checklist authors and their agents tick off.
cc @mo271