chore: sparkle-design-cli 2.4.1 で sparkle-design.css を再生成 by touyou · Pull Request #289 · goodpatch/sparkle-design

touyou · 2026-07-10T06:23:01Z

Summary

sparkle-design-cli v2.4.1（goodpatch/sparkle-design-cli#69）で @theme inline のセマンティック宣言をプリミティブ直接参照から自己参照に変更する不具合修正が入ったため、sparkle-design.css を再生成
詳細な背景: goodpatch/sparkle-design-internal#229

影響

生成物のみの差分（@theme inline ブロックの内部参照方法のみ）。現状の運用（属性スコープでの上書きを使わない default 表示）には一切影響しません
Storybook で Button（全 variant）/ Switch / Tabs (line variant) の表示をピクセル差分ゼロで確認済み（bbox=None, max_channel_diff=0）

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

@theme

@theme inline のセマンティック宣言をプリミティブ直接参照から自己参照に変更する不具合修正（goodpatch/sparkle-design-internal#229 フォローアップ、 sparkle-design-cli v2.4.1）を取り込む。生成物のみの変更で、デフォルト表示（属性スコープでの上書きを使わない現状の運用）には影響しない（Storybook で Button/Switch/Tabs をピクセル差分ゼロで確認済み）。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

coderabbitai · 2026-07-10T06:23:09Z

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 59 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3acae9bd-d270-45eb-9e92-e055b03a33a9

📥 Commits

Reviewing files that changed from the base of the PR and between 0b7d233 and 048866d.

📒 Files selected for processing (1)

src/app/sparkle-design.css

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch worktree-regen-cli-2.4.1

_{Comment @coderabbitai help to get the list of available commands.}

vercel · 2026-07-10T06:23:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
sparkle-design	Ready	Preview, Comment	Jul 10, 2026 6:49am

Copilot

Pull request overview

sparkle-design-cli v2.4.1 の修正（@theme inline のセマンティック宣言がプリミティブ直参照になってしまう問題）に追従して、sparkle-design.css の Tailwind v4 用トークン定義を再生成し、ランタイム上書き可能なセマンティック変数参照を維持するための更新です。

Changes:

@theme inline 内のセマンティックトークンを、プリミティブ直参照から「同名のセマンティック変数の自己参照」に変更
変更理由と Tailwind v4 のインライン化挙動に関する説明コメントを追加

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 985930e352

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-10T06:25:57Z

+  --color-primary-200: var(--color-primary-200);
+  --color-primary-300: var(--color-primary-300);
+  --color-primary-400: var(--color-primary-400);
+  --color-primary-500: var(--color-primary-500);


Avoid publishing self-referential registry theme vars

When make registry runs, scripts/build-sparkle-design-theme.mjs reads the @theme inline block and merges those declarations over the first :root block before writing sparkle-design-theme.json; with this self-reference pattern, the generated registry theme contains entries like color-primary-500: var(--color-primary-500). Registry consumers receive only those cssVars, so the variable is defined in terms of itself and semantic colors/radii/shadows become unresolved even though importing the full CSS in this app still works.

Useful? React with 👍 / 👎.

@theme

@theme inline 自己参照コメントを簡潔にし、社内 issue 番号への言及を削除した sparkle-design-cli v2.4.2 を反映。生成される CSS は公開 npm パッケージにも同梱され消費側の CSS にそのまま出力されるため、社内 issue 番号を含めるべきではなかった。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 10, 2026 06:23

Copilot started reviewing on behalf of touyou July 10, 2026 06:23 View session

vercel Bot deployed to Preview July 10, 2026 06:24 View deployment

Copilot AI reviewed Jul 10, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 10, 2026 06:47

Copilot started reviewing on behalf of touyou July 10, 2026 06:48 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

vercel Bot deployed to Preview July 10, 2026 06:49 View deployment

touyou mentioned this pull request Jul 10, 2026

fix: build-sparkle-design-theme.mjs が @theme inline の自己参照で壊れる問題を修正 #290

Merged

touyou merged commit 2ec414c into main Jul 10, 2026
5 checks passed

touyou deleted the worktree-regen-cli-2.4.1 branch July 10, 2026 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: sparkle-design-cli 2.4.1 で sparkle-design.css を再生成#289

chore: sparkle-design-cli 2.4.1 で sparkle-design.css を再生成#289
touyou merged 2 commits into
mainfrom
worktree-regen-cli-2.4.1

touyou commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

Review limit reached

Uh oh!

vercel Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

touyou commented Jul 10, 2026

Summary

影響

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

vercel Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

vercel Bot commented Jul 10, 2026 •

edited

Loading