Skip to content

crypto/ocsp: clarify ParseRequest multi-request behavior #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notedavidrinaldi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crypto/ocsp: clarify ParseRequest multi-request behavior #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ocsp/ocsp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,11 @@ func (p ParseError) Error() string {
return string(p)
}

// ParseRequest parses an OCSP request in DER form. It only supports
// requests for a single certificate. Signed requests are not supported.
// ParseRequest parses an OCSP request in DER form.
// It only supports requests for a single certificate.
// If the request contains multiple requests, ParseRequest will use the first
// request and ignore the rest.
// Signed requests are not supported.
// If a request includes a signature, it will result in a ParseError.
func ParseRequest(bytes []byte) (*Request, error) {
var req ocspRequest
Expand Down