Skip to content

fix(cli): propagate eventaddr to TLS probes - #1027

Merged
cfc4n merged 1 commit into
gojue:masterfrom
zidonghua-source:fix/propagate-eventaddr-to-tls-probes
Aug 18, 2026
Merged

fix(cli): propagate eventaddr to TLS probes#1027
cfc4n merged 1 commit into
gojue:masterfrom
zidonghua-source:fix/propagate-eventaddr-to-tls-probes

Conversation

@zidonghua-source

Copy link
Copy Markdown
Contributor

tls and gotls accepted --eventaddr, but did not propagate it from
the CLI configuration to their probe configurations.

As a result, BaseProbe.Initialize received an empty event collector
address and selected LoggerWriter, so no TCP/WebSocket/file event
writer was created even though the command line and startup log showed
the requested --eventaddr.

Propagate globalConf.EventCollectorAddr to both configurations.

Tested on Android arm64:

  • Device can connect to the TCP receiver at 192.168.1.57:9000.
  • Before this change, TLS reported writer=LoggerWriter.
  • With this change, TLS reports writer=tcp://192.168.1.57:9000 and
    the receiver accepts a connection from the device.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. fix bug fix PR labels Aug 15, 2026

@cfc4n cfc4n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 17, 2026
@cfc4n
cfc4n merged commit 1bdc3e4 into gojue:master Aug 18, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix bug fix PR lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants