fix(config): handle directory paths for --config and HARBOR_CLI_CONFIG

[Jay2006sawant]

Description

Briefly describe what this pull request does and why the change is needed.

• Fixes [bug]: Config directory path via --config or HARBOR_CLI_CONFIG corrupts data.yaml and bricks CLI #993

When --config or HARBOR_CLI_CONFIG pointed to a directory (as documented in the README), Harbor CLI persisted that directory path into data.yaml before validating it was a file. This caused a fatal error on every subsequent run until data.yaml was manually repaired.

This PR resolves directory paths to <dir>/config.yaml and ensures the config file is validated before updating data.yaml.

Type of Change

Please select the relevant type.

• Bug fix
• New feature
• Refactor
• Documentation update
• Chore / maintenance

Changes

• Add normalizeConfigPath to resolve directory paths to config.yaml for --config and HARBOR_CLI_CONFIG
• Reorder InitConfig to call EnsureConfigFileExists before ApplyDataFile, preventing invalid paths from being persisted
• Add unit tests for directory-based config paths (Test_Config_EnvVar_Directory, Test_Config_Flag_Directory)

Test plan

• go test ./pkg/utils/... -run Test_Config
• harbor -c ~/.config/harbor-cli version — exits 0, data.yaml stores file path
• HARBOR_CLI_CONFIG=$HOME/.config/harbor-cli harbor version — exits 0
• Subsequent harbor version runs work without manual data.yaml repair

[Jay2006sawant]

@Vad1mo PTAL!

[qcserestipy]

Thank you for catching this! This can be simplified by just checking for file or dir in DetermineConfigPath. Added tests and normalization function can therefore be removed/adapted.

[qcserestipy]

the cli should return an error instead of automagically appending a config.yaml suffix. it should be enough to check here whether the path is a file or dir. if dir fail

[qcserestipy]

@Jay2006sawant Please check out the suggested changes

[codecov]

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.18%. Comparing base (60ad0bd) to head (467b2a0).
⚠️ Report is 188 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/utils/config.go	63.63%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             main    #994      +/-   ##
=========================================
- Coverage   10.99%   9.18%   -1.81%     
=========================================
  Files         173     321     +148     
  Lines        8671   16083    +7412     
=========================================
+ Hits          953    1478     +525     
- Misses       7612   14472    +6860     
- Partials      106     133      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.