test: add Unit Test Coverage for Reflect Util#1026
Open
kartikangiras wants to merge 2 commits into
Open
Conversation
kartikangiras
force-pushed
the
test/reflectutil
branch
from
db2e4a2 to
47f39c1
Compare
qcserestipy
added
the
status/in-progress
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests for the reflection-based configuration utilities in pkg/utils/reflect.go, improving confidence in config extraction/conversion and category filtering logic used by the CLI.
Changes:
- Add unit tests for
ExtractConfigValuesacrossConfigurationsandConfigurationsResponse, including nil/empty-string handling. - Add unit tests for
ConvertToConfigurations,ExtractConfigurationsByCategory, andIsCategory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
kartikangiras
force-pushed
the
test/reflectutil
branch
from
1a54c3e to
73bee7e
Compare
Author
|
Hey @qcserestipy , I have made changes and resolved the review remarks. Could you PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit test coverage for pkg/utils/reflect.go (ExtractConfigValues, ConvertToConfigurations, ExtractConfigurationsByCategory, IsCategory).
Type of Change
Please select the relevant type.
Changes