fix(preheat): handle nil payload during policy update

cmd/harbor/root/project/preheat/policy/update.go

@@ -26,6 +26,10 @@ import (
 	"github.com/spf13/cobra"
 )
 
+var (
+	getPreheatPolicyFunc = api.GetPreheatPolicy
+)
+
 func UpdatePolicyCommand() *cobra.Command {
 	var isID bool
 
@@ -75,14 +79,18 @@ func UpdatePolicyCommand() *cobra.Command {
 			}
 
 			log.Debug("Fetching preheat policy...")
-			existingPolicy, err := api.GetPreheatPolicy(projectName, policyName)
+			existingPolicy, err := getPreheatPolicyFunc(projectName, policyName)
 			if err != nil {
 				if utils.ParseHarborErrorCode(err) == "404" {
 					return fmt.Errorf("preheat policy %s not found in project %s", policyName, projectName)
 				}
 				return fmt.Errorf("failed to get preheat policy: %v", utils.ParseHarborErrorMsg(err))
 			}
 
+			if existingPolicy == nil || existingPolicy.Payload == nil {
+				return fmt.Errorf("preheat policy %s payload is empty", policyName)
+			}
+
 			log.Debug("Fetching available providers...")
 			providers, err := api.ListProvidersUnderProject(projectName)
 			if err != nil {

cmd/harbor/root/project/preheat/policy/update_test.go

@@ -0,0 +1,65 @@
+// Copyright Project Harbor Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package policy
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/goharbor/go-client/pkg/sdk/v2.0/client/preheat"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestUpdatePolicyCommand_NilPolicy(t *testing.T) {
+	originalGetPreheatPolicy := getPreheatPolicyFunc
+	t.Cleanup(func() {
+		getPreheatPolicyFunc = originalGetPreheatPolicy
+	})
+
+	getPreheatPolicyFunc = func(projectName, policyName string) (*preheat.GetPolicyOK, error) {
+		return nil, nil
+	}
+
+	cmd := UpdatePolicyCommand()
+	var buf bytes.Buffer
+	cmd.SetOut(&buf)
+	cmd.SetErr(&buf)
+	cmd.SetArgs([]string{"my-project", "my-policy"})
+
+	err := cmd.Execute()
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "payload is empty")
+}
+
+func TestUpdatePolicyCommand_NilPayload(t *testing.T) {
+	originalGetPreheatPolicy := getPreheatPolicyFunc
+	t.Cleanup(func() {
+		getPreheatPolicyFunc = originalGetPreheatPolicy
+	})
+
+	getPreheatPolicyFunc = func(projectName, policyName string) (*preheat.GetPolicyOK, error) {
+		return &preheat.GetPolicyOK{Payload: nil}, nil
+	}
+
+	cmd := UpdatePolicyCommand()
+	var buf bytes.Buffer
+	cmd.SetOut(&buf)
+	cmd.SetErr(&buf)
+	cmd.SetArgs([]string{"my-project", "my-policy"})
+
+	err := cmd.Execute()
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "payload is empty")
+}