fix(cli): correct spelling typo and append newline to apply output#1015
Open
saiashok0981 wants to merge 1 commit into
Open
fix(cli): correct spelling typo and append newline to apply output#1015saiashok0981 wants to merge 1 commit into
saiashok0981 wants to merge 1 commit into
Conversation
Collaborator
|
@saiashok0981 Thank you for your contribution, please fix the failing DCO before merging this. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=========================================
- Coverage 10.99% 9.34% -1.65%
=========================================
Files 173 321 +148
Lines 8671 16082 +7411
=========================================
+ Hits 953 1503 +550
- Misses 7612 14445 +6833
- Partials 106 134 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: saiashok103@gmail.com Signed-off-by: saiashok0981 <saiashok103@gmail.com>
1f0050b to
76b1be3
Compare
Author
|
Hi @qcserestipy, thank you for the review! I've fixed the failing DCO git config user.name was not set globally, which caused the Signed-off-by to be malformed. I've amended the commit with the correct sign-off (Signed-off-by: saiashok0981 saiashok103@gmail.com) and force-pushed. Please take another look when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1041
Summary
This PR applies formatting and spelling polish to two CLI commands:
replication startoutput ("Repliation" -> "Replication").config applysuccess print statement to prevent shell prompt overlap.Signed-off-by: saiashok103@gmail.com