Skip to content

fix(cli): correct spelling typo and append newline to apply output#1015

Open
saiashok0981 wants to merge 1 commit into
goharbor:mainfrom
saiashok0981:fix/cli-output-typo-and-newline
Open

fix(cli): correct spelling typo and append newline to apply output#1015
saiashok0981 wants to merge 1 commit into
goharbor:mainfrom
saiashok0981:fix/cli-output-typo-and-newline

Conversation

@saiashok0981

@saiashok0981 saiashok0981 commented Jun 22, 2026

Copy link
Copy Markdown

Closes #1041

Summary

This PR applies formatting and spelling polish to two CLI commands:

  • Fixes a typo in replication start output ("Repliation" -> "Replication").
  • Adds a missing trailing newline in config apply success print statement to prevent shell prompt overlap.
    Signed-off-by: saiashok103@gmail.com

@qcserestipy

Copy link
Copy Markdown
Collaborator

@saiashok0981 Thank you for your contribution, please fix the failing DCO before merging this.

@qcserestipy qcserestipy added invalid This doesn't seem right Changes Requesed feedback that must be addressed before merging. status/in-progress Work on this issue has started or a linked pull request is actively being developed. labels Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.34%. Comparing base (60ad0bd) to head (1f0050b).
⚠️ Report is 191 commits behind head on main.

Files with missing lines Patch % Lines
cmd/harbor/root/configurations/apply.go 0.00% 1 Missing ⚠️
cmd/harbor/root/replication/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #1015      +/-   ##
=========================================
- Coverage   10.99%   9.34%   -1.65%     
=========================================
  Files         173     321     +148     
  Lines        8671   16082    +7411     
=========================================
+ Hits          953    1503     +550     
- Misses       7612   14445    +6833     
- Partials      106     134      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: saiashok103@gmail.com
Signed-off-by: saiashok0981 <saiashok103@gmail.com>
@saiashok0981 saiashok0981 force-pushed the fix/cli-output-typo-and-newline branch from 1f0050b to 76b1be3 Compare July 6, 2026 18:05
@saiashok0981

Copy link
Copy Markdown
Author

Hi @qcserestipy, thank you for the review! I've fixed the failing DCO git config user.name was not set globally, which caused the Signed-off-by to be malformed. I've amended the commit with the correct sign-off (Signed-off-by: saiashok0981 saiashok103@gmail.com) and force-pushed. Please take another look when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requesed feedback that must be addressed before merging. invalid This doesn't seem right status/in-progress Work on this issue has started or a linked pull request is actively being developed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): correct spelling typo and missing newline in CLI output

2 participants