Skip to content

fix: stop mutating package-level columns variable in member list view #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdeshDeshmukh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop mutating package-level columns variable in member list view #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/views/member/list/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ var columns = []table.Column{

func ListMembers(members []*models.ProjectMemberEntity, wide bool) {
var rows []table.Row
localColumns := columns

if !wide {
colsToRemove := []string{"Role ID", "Project ID"}
localColumns = utils.RemoveColumns(localColumns, colsToRemove)
}

for _, member := range members {
memberID := strconv.FormatInt(member.ID, 10)
roleName := utils.CamelCaseToHR(member.RoleName)
Expand All @@ -61,18 +68,16 @@ func ListMembers(members []*models.ProjectMemberEntity, wide bool) {
projectID,
})
} else {
colsToRemove := []string{"Role ID", "Project ID"}
columns = utils.RemoveColumns(columns, colsToRemove)
rows = append(rows, table.Row{
memberID, // Member Name
memberID,
member.EntityName,
memberType,
roleName,
})
}
}

m := tablelist.NewModel(columns, rows, len(rows))
m := tablelist.NewModel(localColumns, rows, len(rows))

if _, err := tea.NewProgram(m).Run(); err != nil {
fmt.Println("Error running program:", err)
Expand Down