Proposal: Probe-Based Authentication Dispatch#288
Open
rossigee wants to merge 5 commits into
Open
Conversation
Comprehensive proposal documenting the completed PAT implementation: - Self-service token management for Harbor users - Time-limited credentials with configurable expiration - Token prefix system (hbr_pat_) for identification - REST API endpoints for CRUD operations and refresh - Harbor UI dashboard for token management - Audit trail integration for compliance - Backward compatibility with legacy CLI tokens - Full test coverage (12/12 E2E tests passing) Implementation PR: goharbor/harbor#23370 Signed-off-by: Ross Golder <ross@golder.org>
Proposes refactoring Harbor's authentication system from single global auth_mode to flexible per-backend matching. Fixes critical issues: - Admin lockout when OIDC provider is unavailable - Security vulnerability: locked users authenticate as nil - Registry proxy bypasses per-user permissions - HTTP Auth Proxy mode non-functional Enables fallback authentication paths while maintaining backward compatibility. PR: goharbor/harbor#23458 Signed-off-by: Ross Golder <ross@golder.org>
- Use standard Discussion field linking to related GitHub issues - Remove non-standard Status/Implementation PR fields - Condense to template format while preserving implementation details - Move detailed technical specs to Implementation and References sections - Follow Harbor community proposal conventions Signed-off-by: Ross Golder <ross@golder.org>
This file belongs on the personal-access-tokens branch only. The probe-based-auth-dispatch branch should contain only auth dispatch proposal changes. Signed-off-by: Ross Golder <ross@golder.org>
Signed-off-by: Ross Golder <ross@golder.org>
rossigee
force-pushed
the
proposal/probe-based-auth-dispatch
branch
from
3df9d09 to
7b28e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes replacing Harbor's single-backend
auth_modeconfiguration with a flexible per-backend matching system. Fixes critical production issues: admin lockout when OIDC provider is unavailable, security vulnerability with locked users, and registry proxy bypassing per-user permissions.Problems Solved
Solution
Match()interface for flexible dispatchRelated Work
Backward Compatibility
✅ All existing
auth_modevalues continue to work✅ No configuration changes required
✅ No database migrations needed
✅ Additive security and reliability improvements