Skip to content

fix: default (index.js) module resolution infinite recursion #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin-Dobell merged 1 commit into from
Apr 20, 2026
Merged

fix: default (index.js) module resolution infinite recursion #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions bridge/jsb_module_resolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace jsb
{
namespace
{
// the cost of copy return is acceptable since Vector copy constructor is by-reference under the hood
// the cost of copy return is acceptable since Vector copy constructor is by-reference under the hood
PackedStringArray get_dynamic_search_paths()
{
#ifdef TOOLS_ENABLED
Expand All @@ -18,7 +18,7 @@ namespace jsb
#endif
}
}

bool IModuleResolver::load_as_json(Environment* p_env, JavaScriptModule& p_module, const String& p_asset_path, const Vector<uint8_t>& p_bytes, size_t p_len)
{
v8::Isolate* isolate = p_env->get_isolate();
Expand Down Expand Up @@ -399,7 +399,12 @@ namespace jsb

if (package_exports.is_empty())
{
// No exports mapping, fall back to absolute resolution
if (p_module_id.is_empty())
{
// Avoid infinite recursion for package root lookups: callers already attempt directory index fallback.
return false;
}

return this->check_absolute_file_path(internal::PathUtil::combine(p_package_path, p_module_id), o_source_info);
}

Expand Down Expand Up @@ -526,7 +531,7 @@ namespace jsb
internal::FileAccessSourceReader reader(p_asset_path);
return load(p_env, p_asset_path, reader, p_module);
}

bool DefaultModuleResolver::load(Environment* p_env, const String& p_asset_path, const internal::ISourceReader& p_reader, JavaScriptModule& p_module)
{
if (p_reader.is_null() || p_reader.get_length() == 0)
Expand Down