Skip to content

fix: Fix decompressed bundled source use after free #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin-Dobell merged 1 commit into from
Apr 20, 2026
Merged

fix: Fix decompressed bundled source use after free #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions weaver-editor/jsb_editor_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,8 @@ Error GodotJSEditorPlugin::apply_file(const jsb::weaver::InstallFileInfo &p_file
}
Error err;
size_t size;
const char* data = get_preset_source(p_file.source_name).get_data(size);
jsb::internal::PresetSource preset = get_preset_source(p_file.source_name);
const char* data = preset.get_data(size);
ERR_FAIL_COND_V_MSG(size == 0 || data == nullptr, ERR_FILE_NOT_FOUND, "bad data");
err = DirAccess::make_dir_recursive_absolute(p_file.target_dir);
ERR_FAIL_COND_V_MSG(err != OK, err, "failed to make dir");
Expand Down Expand Up @@ -396,7 +397,8 @@ bool GodotJSEditorPlugin::verify_file(const jsb::weaver::InstallFileInfo& p_file
}

size_t size;
const char* data = get_preset_source(p_file.source_name).get_data(size);
jsb::internal::PresetSource preset = get_preset_source(p_file.source_name);
const char* data = preset.get_data(size);
if (size == 0 || data == nullptr) return false;
const String target_name = jsb::internal::PathUtil::combine(p_file.target_dir, p_file.source_name);
if (!FileAccess::exists(target_name)) return false;
Expand Down
Loading