Skip to content

Fix compiling core/profiling files with Perfetto profiler#120733

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Mister-Ky:patch-3
Jun 29, 2026
Merged

Fix compiling core/profiling files with Perfetto profiler#120733
Repiteo merged 1 commit into
godotengine:masterfrom
Mister-Ky:patch-3

Conversation

@Mister-Ky

@Mister-Ky Mister-Ky commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Refined #118856

I didn't look in any other places for the operator String(), I only came across it myself in core/profiling.

@Mister-Ky Mister-Ky requested a review from a team as a code owner June 29, 2026 14:46

@Ivorforce Ivorforce left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, dang, I really should have caught those. Thanks!

@Ivorforce Ivorforce added this to the 4.8 milestone Jun 29, 2026
@akien-mga

Copy link
Copy Markdown
Member

@Ivorforce Do those need converting too?

platform/web/javascript_bridge_singleton.cpp
230:                    CharString *cs = memnew(CharString(v->operator String().utf8()));

drivers/vulkan/rendering_context_driver_vulkan.cpp
700:    CharString cs = GLOBAL_GET("application/config/name").operator String().utf8();

core/io/plist.cpp
115:                    node->data_string = p_value.operator String().utf8();

@AThousandShips

Copy link
Copy Markdown
Member

Those are all Variant so not sure if it applies to them

@akien-mga akien-mga changed the title Fix compile core/profiling files Fix compiling core/profiling files with Perfetto profiler Jun 29, 2026
@Repiteo Repiteo merged commit 77c0879 into godotengine:master Jun 29, 2026
20 checks passed
@Repiteo

Repiteo commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants