avoid running 'GetVolumeInformationW' on network drives#120666
Open
dukeman74 wants to merge 1 commit into
Open
avoid running 'GetVolumeInformationW' on network drives#120666dukeman74 wants to merge 1 commit into
dukeman74 wants to merge 1 commit into
Conversation
Calinou
added
bug
platform:windows
platform:ios
topic:platforms
and removed
platform:ios
labels
Calinou
added
the
cherrypick:4.7
bruvzg
reviewed
Jun 27, 2026
bruvzg
left a comment
bruvzg
left a comment
Member
There was a problem hiding this comment.
Code seems fine. Have not tested it. It would make sense to process labels asynchronously, bu this will require more changes to file dialogs, so it should be ok to skip network drives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Additional information
checks whether a drive is a network drive before querying it with GetVolumeInformationW, which I have noticed hangs for about 8 seconds on disconnected network drives.
I don't know that this is the best way to resolve this, but it is a way.
I tested by launching godot editor with and without this change and without it it hangs for ~30 seconds and with it it opens right away