Skip to content

Improve shader and editor error reporting#120664

Open
moluopro wants to merge 8 commits into
godotengine:masterfrom
moluopro:master
Open

Improve shader and editor error reporting#120664
moluopro wants to merge 8 commits into
godotengine:masterfrom
moluopro:master

Conversation

@moluopro

@moluopro moluopro commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What problems does this PR solve?

Some RD shader compilation failures did not print detailed diagnostics through Godot's standard error reporting path. As a result, those details were not shown in the editor Output panel or terminal.

When multiple errors were reported during editor load or import, the editor could also try to pop up the same error dialog repeatedly.

Changes

  • Print .glsl import errors and RenderingDevice shader compilation errors through Godot's standard error reporting path.
  • Include shader stage names in diagnostics, and avoid repeating the full compile log when shader creation uses bytecode whose compile error was already printed.
  • Complete the existing shader stage name table for ray tracing stages.
  • Keep detailed compile errors available for RDShaderSPIRV resources with compile errors.
  • Avoid repeated popup attempts while the editor Load Errors dialog is already visible, and safely defer shader import Load Errors messages to the main thread.

@moluopro moluopro requested review from a team as code owners June 26, 2026 15:07
Comment thread servers/rendering/rendering_device.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants