feat: omit blank tag names from namespace - #1567
Merged
nodivbyzero merged 1 commit intoMay 26, 2026
Merged
Conversation
This was referenced Apr 23, 2026
Contributor
|
Thanks, will try and review tonight after work. |
zemzale
approved these changes
Apr 27, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
When
RegisterTagNameFuncreturns""(typically forjson:"-"or equivalent), the field currently falls back to the struct field name in error namespaces, defeating the tag-name remapping.This PR adds the WithTagNameFuncBlankOmit option that preserves the blank and omits the field from the error namespace - nested struct levels collapse, and leaf field namespaces trim the trailing separator.
Gated behind an option for v10 backward compatibility. According to @deankarn this was always meant to be the behaviour (see #1426 (comment)) so I've gone off the assumption this will be the default in v11 and followed the example of
WithRequiredStructEnabled.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers