Skip to content

Add Apply button to preferences - #1115

Merged
mattrose merged 1 commit into
gnome-terminator:masterfrom
damyan94:preferences-apply-button
Sep 6, 2026
Merged

Add Apply button to preferences#1115
mattrose merged 1 commit into
gnome-terminator:masterfrom
damyan94:preferences-apply-button

Conversation

@damyan94

@damyan94 damyan94 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an Apply button to the Preferences window.
  • Apply configuration changes without closing Preferences.
  • Keep the user on the currently selected page and profile.
  • Reuse the same Apply path when closing Preferences.

This makes it easier to adjust settings interactively without repeatedly
closing and reopening the Preferences window.

Verification

  • Python syntax parsing passed.
  • Glade XML parsing passed.
  • Manually verified that Apply updates open terminals without closing
    Preferences.
  • Manually verified that Apply can be used repeatedly.
  • Close behavior remains unchanged.

Notes

The existing Discard Changes behavior is not modified by this pull request.
Its runtime rollback behavior appears to be a separate pre-existing issue.

AI assistance

Codex assisted with codebase inspection and implementation.

@mattrose

mattrose commented Sep 6, 2026

Copy link
Copy Markdown
Member

This also looks good. TYSM

@mattrose
mattrose merged commit db2b06b into gnome-terminator:master Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants