Confirm screenshot Copy to Clipboard visually#698
Open
kud wants to merge 4 commits into
Open
Conversation
kud
force-pushed
the
fix/screenshot-copy-feedback
branch
from
July 5, 2026 00:20
92a7ba7 to
5f451d5
Compare
The Copy to Clipboard button wrote the image to the pasteboard but gave no UI feedback, unlike Save (which closes the panel), so the button read as dead even though the copy succeeded. Flash a green “Copied!” confirmation on the button for ~1.2s in both the standard and streaming copy paths, reverting via a generation-guarded timer so a rapid second copy can’t stomp it.
kud
force-pushed
the
fix/screenshot-copy-feedback
branch
from
July 11, 2026 14:21
5f451d5 to
9a5ea90
Compare
Contributor
Author
|
Heads-up: the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The screenshot window's Copy to Clipboard button gives no UI feedback. It writes the image to the pasteboard and returns — no panel close, no label change, nothing. Because the sibling Save button looks like it worked only by closing the panel, Copy reads as a dead button even though the clipboard is correctly populated.
Fix
Add a transient confirmation: on copy, the button briefly becomes a green checkmark + "Copied!" for ~1.2 s, then reverts to its normal title. Wired into both copy paths (
copyClicked(_:)andcopyToClipboardFromFile(_:)), so it fires regardless of which one handles the image.Implementation notes:
copyFeedbackGenerationcounter invalidates a prior revert timer, so a rapid second copy can't leave the label stuck or revert early.SFSymbol.checkmarkCircleFill.rawValuerather than a raw SF Symbol string literal, per the project's convention.cachedNumberOfParts > 1.Notes
docs/notes-3.7.txt.tools/build.sh) — compiles clean.