Upgrade to use glossarist-ruby 2.11.3 - #21
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades Termium’s Glossarist integration to work with glossarist ~> 2.11.3, including adjustments to how concepts/localizations are constructed/serialized and adding regression tests to cover the updated behavior.
Changes:
- Bump
glossaristdependency to~> 2.11.3. - Update concept/localized-concept construction to align with newer Glossarist data-backed models and date handling.
- Expand RSpec coverage for identifiers, localizations, dates, and standalone
save_to_filesbehavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| termium.gemspec | Bumps the glossarist runtime dependency to ~> 2.11.3. |
| spec/termium_spec.rb | Replaces the minimal spec with a broader suite covering YAML output and standalone save behavior. |
| lib/termium/language_module.rb | Adjusts localized concept hash structure and uses LocalizedConcept.of_yaml, plus wraps notes/examples. |
| lib/termium/core.rb | Updates managed concept construction to avoid data default-mutation serialization issues and refactors localization building. |
| lib/termium.rb | Requires fileutils to prevent runtime NameError when saving via Glossarist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to lutaml/lutaml-model#720
Fixes failures in https://github.com/lutaml/lutaml-model/actions/runs/29395937178/job/87289436544?pr=720