feat(sphere): legend row toggle + info icon link - #210
Merged
Conversation
- Entire legend row is now a toggle (click anywhere = toggle on/off) - Swatch + count + label are visual only (no separate button) - Added ? info icon that opens /learn/relationships#type in new tab - @click.stop on info icon prevents toggling when clicking the link - role=switch + aria-checked for accessibility - Removed sp-legend-toggle button wrapper (no longer needed) - Removed sp-legend-label router-link (replaced with plain span)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legend rows in the relation sphere are now full-row toggles with an info icon.
Changes:
?info icon opens/learn/relationships#typein a new tab@click.stopon the info icon prevents accidental togglingrole="switch"+aria-checkedfor accessibilityTest plan