chore(ci): delete release-patch.yml — one workflow for trusted publishing - #176
Open
ronaldtse wants to merge 1 commit into
Open
chore(ci): delete release-patch.yml — one workflow for trusted publishing#176ronaldtse wants to merge 1 commit into
ronaldtse wants to merge 1 commit into
Conversation
…hing release-patch.yml was a parallel workflow that auto-bumped version, auto-committed to main, auto-tagged, and triggered release.yml. That's a separate trust boundary from release.yml's tag-push trigger and created a path where one workflow_dispatch click (with just a dry_run toggle) could cause a release. Trusted npm publishing must go through exactly one workflow: release.yml, triggered by a maintainer-pushed v* tag. The maintainer decides when to tag (and therefore when to release); the version in package.json is bumped via PR as part of normal code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete
release-patch.yml. There must be exactly one workflow for trusted npm publishing —release.yml.Why delete
release-patch.ymlwas a parallel workflow that:release.ymlAll from a single
workflow_dispatchclick with just adry_runtoggle. That's a separate trust boundary fromrelease.yml's tag-push trigger and created a path where one workflow_dispatch click could cause a release.The correct release flow
0.7.105 → 0.7.106)v0.7.106tagrelease.ymlauto-triggers → tests → smoke gate →npm publish --provenanceTags are releases. The maintainer decides when to tag — not a workflow.
Test plan
release.ymlstill triggers on tag push (unchanged)release-patch.ymlno longer exists in.github/workflows/